Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a potential deadlock in JDTextField #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Found a potential deadlock in JDTextField #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/JDTextField/JDTextField.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,14 @@ open class JDTextField: UITextField {

private extension JDTextField {

/// A problem appeard when I add extra option to the field to hide or show user's inputs (isSecureTextEntry).
/// When 'isSecureTextEntry == true' on the first field and I try to switch on another app just block UI and its seems
/// like deadlock is happened. I found that program stops on 97 line.
/// After commenting a line problem was resolved for me and app continued working well as expected.

func setColors() {
allLayers.forEach { $0.strokeColor = shapeColor.cgColor }
self.textColor = tintColor
// >>> potential deadlock >>> self.textColor = tintColor
floatingLabel.textColor = isFirstResponder ? tintColor : shapeColor
errorLabel.textColor = errorLabelColor
}
AlexSiarheyeu marked this conversation as resolved.
Show resolved Hide resolved
Expand Down