Add synchronous jobs #131
Open
Add synchronous jobs #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
We needed a possibility to execute some jobs / queries synchronously every time /metrics is requested. So I added the infrastructure to execute jobs with an interval <= 0 synchronously when the http-handler is called. interval: '0s' # an interval <= 0 will make the queries synchronous Some typos fixed by Felix Hillingshaeuser, thanks!
mbanck-ntap
force-pushed
the
synchronous-jobs
branch
from
be16a1f to
04d0b6f
Compare
|
Did somebody take a look at this? |
|
Hey @mbanck-ntap, I don't really have time to test it, but it looks good to me and as everything is limited to the Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed a possibility to execute some jobs / queries synchronously every time /metrics is requested. So I added the infrastructure to execute jobs with an interval <= 0 synchronously when the http-handler is called.
interval: '0s' # an interval <= 0 will make the queries synchronous
This is a rebase and re-submission from #10 which erroneously got marked as merged a while ago.