Support emacs 29.1 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In emacs 29.1 format-time-string no longer wraps time strings
in their corresponding square brackets ("[", "]"). This breaks
org-clock-split in its current form.
This adds a function that provides a proper inactive time string, with the
wrapped square brackets if it does not yet have them (meaning it'll support both
emacs 28 and 29+).
Also removes one superfluous test that is already handled in the larger
duplicated org-clock-split-split-line-test.
In emacs-29.1 timestamps with incorrect day names will be automatically updated as part of the timestamp formatting functions, this revealed the test cases where the selected day was incorrect (2019-12-17 was a Tuesday not a Wednesday). This updates both the expected values and the source values of the test cases (source values are updated because the tests would otherwise fail on emacs-28.2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the values in
org-time-stamp-formatsno longer contain the<and>markers in emacs-29.1.This leads to the functionality of org-clock-split not working as values that were expected to be inactive timestamps no longer are.
This changes the default value for the
org-clock-split-inactive-timestamp-hmvariable to once again include the inactive markers.I also performed a few changes on the tests to work in both emacs-28.2 and emacs-29.1.