Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big update #42

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pencilheart
Copy link

@pencilheart pencilheart commented Dec 7, 2024

You can try this version, say goodbye to robot test and wait time.

Xnip2024-12-07_21-56-49

@justinribeiro justinribeiro marked this pull request as draft December 11, 2024 17:17
@justinribeiro
Copy link
Owner

I appreciate the work and enthusiasm. That said, I can't merge this in it's current state. There are some common/general things one must do when contributing (regardless of project):

  1. Big PRs like this are hard to merge because the concerns are mixed; subsequently stuff in the v4.2.0 milestone are going to clash.
  2. Don't bump the version. That's a release activity, not a PR activity.
  3. Don't strip functionality unless it was agreed prior. You've pulled out the randomWait which is there for a reason.
  4. You haven't added any test coverage to account for the changes, so now this branch has additional issues.

I think we can get this PR over the line, but it'll likely take some time as I land a couple of the other items that need to go for v4.2.0.

@pencilheart
Copy link
Author

Thanks, I will check after v4.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants