Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): Remove Adyen-specific deprecated PMTs Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort #7099

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arindam-sahoo
Copy link
Contributor

@arindam-sahoo arindam-sahoo commented Jan 24, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR addresses two issues related to the Adyen connector deprecated PMTs in the payment flow:

  1. Postman Collection Update: Removed the Sofort and Trustly test cases from the Adyen connector in the Postman collection because these payment methods are deprecated by Adyen Connector.
  2. Cypress Test Update: Added a conditional assertion for the error message ("Required object 'paymentMethod' is not provided.") in the Sofort redirect flow for the Adyen connector.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • The Postman test cases for Sofort and Trustly are no longer valid for the Adyen connector, as Adyen has deprecated these PMTs.
  • The Cypress tests for Sofort needed an update to conditionally check the error message when the connector is Adyen.

How did you test it?

  • Postman Collection
    Before
    image
    After
    image

  • Cypress Test Case
    Before
    image
    After
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@arindam-sahoo arindam-sahoo self-assigned this Jan 24, 2025
@arindam-sahoo arindam-sahoo requested a review from a team as a code owner January 24, 2025 09:47
Copy link

semanticdiff-com bot commented Jan 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/e2e/PaymentTest/00018-BankRedirect.cy.js  27% smaller
  postman/collection-json/adyen_uk.postman_collection.json  1% smaller

@arindam-sahoo arindam-sahoo changed the title Remove Adyen-specific Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort refactor(ci): remove Adyen-specific Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort Jan 24, 2025
@arindam-sahoo arindam-sahoo added the A-CI-CD Area: Continuous Integration/Deployment label Jan 24, 2025
@arindam-sahoo arindam-sahoo changed the title refactor(ci): remove Adyen-specific Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort refactor(ci): remove Adyen-specific deprecated PMTs Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a9a1ded). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7099   +/-   ##
=======================================
  Coverage        ?    4.12%           
=======================================
  Files           ?     1010           
  Lines           ?   207403           
  Branches        ?        0           
=======================================
  Hits            ?     8548           
  Misses          ?   198855           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arindam-sahoo arindam-sahoo added this to the January 2025 Release milestone Jan 24, 2025
@arindam-sahoo arindam-sahoo changed the title refactor(ci): remove Adyen-specific deprecated PMTs Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort refactor(ci): Remove Adyen-specific deprecated PMTs Sofort and Trustly test cases in Postman and add conditional assertion in Cypress for Sofort Jan 24, 2025
@arindam-sahoo arindam-sahoo removed this from the January 2025 Release milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Remove Deprecated Adyen PMTs Sofort and Trustly Test Cases
1 participant