Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add core changes for external authentication flow through unified_authentication_service #7063

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Jan 18, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add core changes for external authentication flow through unified_authentication_service

Currently, Only ClickToPay is supported through Unified Authentication Service. This PR adds support to perform external authentication through connectors like Netcetera, through Unified Authentication service.

  1. Add authentication flow in UnifiedAuthenticationService trait
  2. Refactor UnifiedAuthenticationService trait
  3. Refactor call_unified_authentication_service_if_eligible in payments confirm operation to support external authentication
  4. Add Authenticate flow for UnifiedAuthenticationService connector integration

Will take up the connector side changes in a separate PR

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compiler guided - Core changes alone done, can be tested after connector related changes are done

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

sahkal and others added 30 commits December 17, 2024 16:21
…2-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
…_id-and-get-the-connector-creds-instead-of-connector_name
…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
…_id-and-get-the-connector-creds-instead-of-connector_name
…_id-and-get-the-connector-creds-instead-of-connector_name
…hanges in pre_auth, post_auth flows for external_authentication
…_id-and-get-the-connector-creds-instead-of-connector_name
SanchithHegde
SanchithHegde previously approved these changes Jan 23, 2025
sahkal
sahkal previously approved these changes Jan 23, 2025
swangi-kumari
swangi-kumari previously approved these changes Jan 23, 2025
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 27, 2025
@Gnanasundari24 Gnanasundari24 removed this pull request from the merge queue due to a manual request Jan 27, 2025
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 31, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
…gh unified_authentication_service (#7063)

Co-authored-by: Sahkal Poddar <[email protected]>
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: Sahkal Poddar <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 31, 2025
@sai-harsha-vardhan sai-harsha-vardhan removed this pull request from the merge queue due to a manual request Jan 31, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Feb 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants