feat(core): Implement 3ds decision manger for V2 #7022

swangi-kumari · 2025-01-10T10:06:32Z

Type of Change

Description

Implement 3ds decision manger for V2
Merchant can configure different 3ds rule for each profile.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Organization Create

curl --location 'http://localhost:8080/v2/organization' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
    "organization_name": "random_org_1736926299"
}'

Merchant Account Create

curl --location 'http://localhost:8080/v2/merchant-accounts' \
--header 'x-organization-id: org_ojPeFJQSwbmYHFykF4Md' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
    "merchant_name": "cloth_seller"
}'

Business Profile Create

curl --location 'http://localhost:8080/v2/profiles' \
--header 'x-merchant-id: cloth_seller_PXTsb0I3Zu2n8E5xWRUD' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data-raw '{
    "profile_name": "business",
    "return_url": "https://google.com/success",
    "enable_payment_response_hash": true,
    "redirect_to_merchant_with_http_post": false,
    "webhook_details": {
        "webhook_version": "1.0.1",
        "webhook_username": "ekart_retail",
        "webhook_password": "password_ekart@123",
        "webhook_url": "https://webhook.site",
        "payment_created_enabled": true,
        "payment_succeeded_enabled": true,
        "payment_failed_enabled": true
    },
    "metadata": null,
    "order_fulfillment_time": 900,
    "order_fulfillment_time_origin": "create",
    "applepay_verified_domains": null,
    "session_expiry": 900,
    "payment_link_config": null,
    "authentication_connector_details": null,
    "use_billing_as_payment_method_billing": true,
    "collect_shipping_details_from_wallet_connector_if_required": false,
    "collect_billing_details_from_wallet_connector_if_required": false,
    "always_collect_shipping_details_from_wallet_connector": false,
    "always_collect_billing_details_from_wallet_connector": false,
    "is_connector_agnostic_mit_enabled": false,
    "payout_link_config": null,
    "outgoing_webhook_custom_http_headers": null
}'

Configure 3ds Rule to that Profile

curl --location --request PUT 'http://localhost:8080/v2/profiles/pro_RuygLuNPMy2PCqcEW96n/decision' \
--header 'x-merchant-id: cloth_seller_PXTsb0I3Zu2n8E5xWRUD' \
--header 'X-Profile-Id: pro_RuygLuNPMy2PCqcEW96n' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_1rmHYg4vdeMtrq77KiCel53UBBoLzvKEfPQfWNQ4lTXTCm4S6Q3OP1uF9uiudmXZ' \
--data '{
    "name": "3DS Rule-2025-01-08",
    "program": {
        "defaultSelection": {
            "override_3ds": null
        },
        "rules": [
            {
                "name": "rule_1",
                "connectorSelection": {
                    "override_3ds": "three_ds"
                },
                "statements": [
                    {
                        "condition": [
                            {
                                "lhs": "amount",
                                "comparison": "equal",
                                "value": {
                                    "type": "number",
                                    "value": 32
                                },
                                "metadata": {}
                            },
                            {
                                "lhs": "currency",
                                "comparison": "equal",
                                "value": {
                                    "type": "enum_variant",
                                    "value": "AMD"
                                },
                                "metadata": {}
                            }
                        ]
                    }
                ]
            }
        ],
        "metadata": {}
    }
}'

Response

{
    "name": "3DS Rule-2025-01-08",
    "program": {
        "defaultSelection": {
            "override_3ds": null
        },
        "rules": [
            {
                "name": "rule_1",
                "connectorSelection": {
                    "override_3ds": "three_ds"
                },
                "statements": [
                    {
                        "condition": [
                            {
                                "lhs": "amount",
                                "comparison": "equal",
                                "value": {
                                    "type": "number",
                                    "value": 32
                                },
                                "metadata": {}
                            },
                            {
                                "lhs": "currency",
                                "comparison": "equal",
                                "value": {
                                    "type": "enum_variant",
                                    "value": "AMD"
                                },
                                "metadata": {}
                            }
                        ],
                        "nested": null
                    }
                ]
            }
        ],
        "metadata": {}
    },
    "created_at": 1736926264
}

Retrive Business Profile

curl --location 'http://localhost:8080/v2/profiles/pro_RuygLuNPMy2PCqcEW96n/decision' \
--header 'x-merchant-id: cloth_seller_PXTsb0I3Zu2n8E5xWRUD' \
--header 'X-Profile-Id: pro_RuygLuNPMy2PCqcEW96n' \
--header 'api-key: dev_1rmHYg4vdeMtrq77KiCel53UBBoLzvKEfPQfWNQ4lTXTCm4S6Q3OP1uF9uiudmXZ'

Response

{
    "name": "3DS Rule-2025-01-08",
    "program": {
        "defaultSelection": {
            "override_3ds": null
        },
        "rules": [
            {
                "name": "rule_1",
                "connectorSelection": {
                    "override_3ds": "three_ds"
                },
                "statements": [
                    {
                        "condition": [
                            {
                                "lhs": "amount",
                                "comparison": "equal",
                                "value": {
                                    "type": "number",
                                    "value": 32
                                },
                                "metadata": {}
                            },
                            {
                                "lhs": "currency",
                                "comparison": "equal",
                                "value": {
                                    "type": "enum_variant",
                                    "value": "AMD"
                                },
                                "metadata": {}
                            }
                        ],
                        "nested": null
                    }
                ]
            }
        ],
        "metadata": {}
    },
    "created_at": 1736926264
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2025-01-10T10:06:35Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payments/conditional_configs.rs	65% smaller
crates/router/src/routes/app.rs	43% smaller
crates/common_types/src/payments.rs	42% smaller
crates/router/src/core/conditional_config.rs	9% smaller
crates/router/src/core/payments.rs	9% smaller
crates/api_models/src/conditional_configs.rs	6% smaller
crates/euclid/src/dssa/types.rs	2% smaller
crates/euclid_wasm/src/lib.rs	2% smaller
Cargo.lock	Unsupported file format
crates/common_types/Cargo.toml	Unsupported file format
crates/diesel_models/src/business_profile.rs	0% smaller
crates/diesel_models/src/schema_v2.rs	0% smaller
crates/euclid_wasm/Cargo.toml	Unsupported file format
crates/hyperswitch_domain_models/src/business_profile.rs	0% smaller
crates/router/src/core/admin.rs	0% smaller
crates/router/src/core/payments/conditional_configs/transformers.rs	0% smaller
crates/router/src/core/routing/helpers.rs	0% smaller
crates/router/src/routes/routing.rs	0% smaller
crates/router/src/services/authorization/permissions.rs	0% smaller
v2_migrations/2025-01-13-181842_add_three_ds_decision_manager_config_in_profile/down.sql	Unsupported file format
v2_migrations/2025-01-13-181842_add_three_ds_decision_manager_config_in_profile/up.sql	Unsupported file format

…types everywhere

Narayanbhat166 · 2025-01-17T13:18:24Z

crates/router/src/core/conditional_config.rs

+
+    let new_algo = common_types::payments::DecisionManagerRecord {
+        name,
+        program: program.clone(),


why do we need to clone this?

Narayanbhat166 · 2025-01-17T13:21:08Z

crates/router/src/core/conditional_config.rs

+        created_at: timestamp,
+    };
+
+    update_merchant_active_algorithm_ref(&state, &key_store, new_algo.clone(), profile)


this function is not performing as its name, this is updating the routing algorithm ref in business profile, so you can call the db interface function directly

Narayanbhat166 · 2025-01-17T13:22:32Z

crates/router/src/core/routing/helpers.rs

@@ -199,13 +199,30 @@ pub async fn update_merchant_active_algorithm_ref(

 #[cfg(feature = "v2")]
 pub async fn update_merchant_active_algorithm_ref(


remove this function

Narayanbhat166 · 2025-01-17T13:28:28Z

crates/common_utils/src/id_type/profile.rs

+impl ProfileId {
+    #[cfg(feature = "v2")]
+    /// get_payment_config_routing_id
+    pub fn get_payment_config_routing_id(&self) -> String {


remove this unused function

Narayanbhat166 · 2025-01-18T06:13:52Z

crates/common_types/src/payments.rs

+#[serde(rename_all = "snake_case")]
+#[strum(serialize_all = "snake_case")]
+/// AuthenticationType
+pub enum AuthenticationType {


we do not need this here, this is already declared in common enums right? we can impl these methods on the AuthenticationType in common enums

…nto 3ds-profile

feat: implement 3ds decision manager on bussiness profile for v2

9ac5796

swangi-kumari added C-feature Category: Feature request or enhancement api-v2 labels Jan 10, 2025

swangi-kumari self-assigned this Jan 10, 2025

swangi-kumari requested review from a team as code owners January 10, 2025 10:06

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Jan 10, 2025

swangi-kumari added 2 commits January 13, 2025 23:22

Merge branch 'main' into 3ds-profile

41d7704

refactor: clippy

1d121e0

swangi-kumari requested a review from a team as a code owner January 13, 2025 18:30

swangi-kumari and others added 4 commits January 14, 2025 00:15

refactor: remove commit

114c699

Merge branch 'main' into 3ds-profile

e9b98d7

refactor: remove Authentication types from api models and use common_…

2441b13

…types everywhere

Merge branch 'main' into 3ds-profile

3fcbc4c

Narayanbhat166 reviewed Jan 18, 2025

View reviewed changes

swangi-kumari added 5 commits January 20, 2025 23:42

refactor: git merge main

257d20a

refactor: resolve comments

4f306c2

Merge branch '3ds-profile' of https://github.com/juspay/hyperswitch i…

a4f5924

…nto 3ds-profile

Merge branch 'main' into 3ds-profile

dbbcd6f

refactor: ref

6928bd5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): Implement 3ds decision manger for V2 #7022

feat(core): Implement 3ds decision manger for V2 #7022

swangi-kumari commented Jan 10, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 10, 2025 •

edited

Loading

Narayanbhat166 Jan 17, 2025

Narayanbhat166 Jan 17, 2025

Narayanbhat166 Jan 17, 2025

Narayanbhat166 Jan 17, 2025

Narayanbhat166 Jan 18, 2025

		@@ -199,13 +199,30 @@ pub async fn update_merchant_active_algorithm_ref(

		#[cfg(feature = "v2")]
		pub async fn update_merchant_active_algorithm_ref(

feat(core): Implement 3ds decision manger for V2 #7022

Are you sure you want to change the base?

feat(core): Implement 3ds decision manger for V2 #7022

Conversation

swangi-kumari commented Jan 10, 2025 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Jan 10, 2025 • edited Loading

Narayanbhat166 Jan 17, 2025

Choose a reason for hiding this comment

Narayanbhat166 Jan 17, 2025

Choose a reason for hiding this comment

Narayanbhat166 Jan 17, 2025

Choose a reason for hiding this comment

Narayanbhat166 Jan 17, 2025

Choose a reason for hiding this comment

Narayanbhat166 Jan 18, 2025

Choose a reason for hiding this comment

swangi-kumari commented Jan 10, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 10, 2025 •

edited

Loading