-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add support for confirmation flow for click to pay #6982
Open
sahkal
wants to merge
26
commits into
main
Choose a base branch
from
7925-feature-add-support-for-confirmation-flow-for-click-to-pay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): add support for confirmation flow for click to pay #6982
sahkal
wants to merge
26
commits into
main
from
7925-feature-add-support-for-confirmation-flow-for-click-to-pay
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
…_id-and-get-the-connector-creds-instead-of-connector_name
…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
…_id-and-get-the-connector-creds-instead-of-connector_name
sahkal
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jan 3, 2025
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 6, 2025
sahkal
changed the base branch from
7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
to
main
January 6, 2025 07:09
hyperswitch-bot
bot
removed
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jan 6, 2025
sahkal
changed the base branch from
main
to
7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
January 6, 2025 09:18
…_id-and-get-the-connector-creds-instead-of-connector_name
…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7925-feature-add-support-for-confirmation-flow-for-click-to-pay
hyperswitch-bot
bot
removed
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 6, 2025
Base automatically changed from
7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
to
main
January 20, 2025 12:02
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 20, 2025
hyperswitch-bot
bot
removed
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Jan 21, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6982 +/- ##
=======================================
Coverage ? 4.11%
=======================================
Files ? 1011
Lines ? 207554
Branches ? 0
=======================================
Hits ? 8548
Misses ? 199006
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for confirmation flow for click to pay
How did you test it?
Add config to make the merchant eligible for authentication service
Create merchant connector account for Ctp_mastercard
Adyen
update business profile with ctp_mastercard mca_id
do payments create
do payments confirm
Expected Response
Look for confirmation call in logs
Checklist
cargo +nightly fmt --all
cargo clippy