refactor: hyperParams generation from a single source #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25harsh
requested changes
Jan 27, 2025
| "launchTime": Int(Date().timeIntervalSince1970 * 1000) | ||
| ] | ||
|
|
||
| if let defaultView = defaultView { |
There was a problem hiding this comment.
please explain the need of passing defaultView, why cant we keep it hardcoded as mentioned earlier ?
There was a problem hiding this comment.
In the file /PaymentSheetView.swift we need the property of defaultView, in all other cases we don't need to pass in defaultView prop.
That's why, exposed defaultView as an optional parameter.
25harsh
reviewed
Jan 27, 2025
| private let deviceModel = UIDevice.current.model | ||
| private let osVersion = UIDevice.current.systemVersion | ||
|
|
||
| func getHyperParams(defaultView: Bool? = nil) -> [String: Any?] { |
There was a problem hiding this comment.
serve from class not function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REFACTOR