-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better mobile device detection for interactive examples buttons #250
Merged
agriyakhetarpal
merged 10 commits into
jupyterlite:main
from
agriyakhetarpal:fix/better-mobile-device-detection
Feb 12, 2025
Merged
Better mobile device detection for interactive examples buttons #250
agriyakhetarpal
merged 10 commits into
jupyterlite:main
from
agriyakhetarpal:fix/better-mobile-device-detection
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
This was referenced Jan 13, 2025
Closed
Carreau
approved these changes
Jan 15, 2025
I rebased and updated the changes to work with the caching of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #140; it moves the logic from the CSS styles for disabling the interactive buttons and uses a better heuristic via our JavaScript code; i.e., the
navigator.userAgent
's value to check what sort of device a user is on. As a fallback, the screen size check has also been kept. A resize handler with 250ms debouncing has also been added here to check the screen size if the buttons haven't been disabled already.I have to note that this also disables them on devices like iPads and other tablets, which can be reconsidered if someone raises this point. The CSS has been removed, as #141 (comment) is not applicable due to the use of user agents to detect the platform.
cc: @gabalafou