Skip to content

Commit

Permalink
fixes - Jupyter AI's broken settings theme
Browse files Browse the repository at this point in the history
  • Loading branch information
MUFFANUJ authored and dlqqq committed Jan 22, 2025
1 parent a0ab1b6 commit 2f377e3
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
1 change: 1 addition & 0 deletions packages/jupyter-ai/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
let settingsWidget: ReactWidget;
try {
settingsWidget = buildAiSettings(
themeManager,
rmRegistry,
completionProvider,
openInlineCompleterSettings
Expand Down
22 changes: 13 additions & 9 deletions packages/jupyter-ai/src/widgets/settings-widget.tsx
Original file line number Diff line number Diff line change
@@ -1,26 +1,30 @@
import React from 'react';
import { ReactWidget } from '@jupyterlab/apputils';
import { IThemeManager, ReactWidget } from '@jupyterlab/apputils';
import { settingsIcon } from '@jupyterlab/ui-components';
import { IRenderMimeRegistry } from '@jupyterlab/rendermime';

import { IJaiCompletionProvider } from '../tokens';
import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
import { ChatSettings } from '../components/chat-settings';
import { JlThemeProvider } from '../components/jl-theme-provider';

export function buildAiSettings(
themeManager: IThemeManager | null,
rmRegistry: IRenderMimeRegistry,
completionProvider: IJaiCompletionProvider | null,
openInlineCompleterSettings: () => void
): ReactWidget {
const SettingsWidget = ReactWidget.create(
<ChatSettings
rmRegistry={rmRegistry}
completionProvider={completionProvider}
openInlineCompleterSettings={openInlineCompleterSettings}
inputOptions={false}
/>
<JlThemeProvider themeManager={themeManager}>
<ChatSettings
rmRegistry={rmRegistry}
completionProvider={completionProvider}
openInlineCompleterSettings={openInlineCompleterSettings}
inputOptions={false}
/>
</JlThemeProvider>
);
SettingsWidget.id = 'jupyter-ai::settings';
SettingsWidget.title.icon = settingsIcon;
SettingsWidget.title.caption = 'Jupyter AI Settings'; // TODO: i18n
return SettingsWidget;
}
}

0 comments on commit 2f377e3

Please sign in to comment.