:fix: pr_json processed as Hash instead of String

juliendms · Nov 6, 2020 · 4a65866 · 4a65866
1 parent 0b58962
commit 4a65866
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-yajp (0.1.0)
+    danger-yajp (0.1.1)
       danger-plugin-api
       jira-ruby
 

diff --git a/lib/yajp/gem_version.rb b/lib/yajp/gem_version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yajp
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end
diff --git a/lib/yajp/plugin.rb b/lib/yajp/plugin.rb
@@ -230,12 +230,10 @@ def vcs_host
     def pr_link
       return @pr_link unless @pr_link.nil?
 
-      pr_hash = JSON.parse(vcs_host.pr_json, symbolize_names: true)
-
       if defined? @dangerfile.gitlab
-        @pr_link = pr_hash[:web_url]
+        @pr_link = vcs_host.pr_json['web_url']
       else
-        @pr_link = pr_hash[:html_url]
+        @pr_link = vcs_host.pr_json['html_url']
       end
 
       return @pr_link

diff --git a/spec/yajp_spec.rb b/spec/yajp_spec.rb
@@ -122,7 +122,7 @@ def issue.find(key)
 
       it 'can add remote link' do
         pr_title = 'PR Title'
-        pr_json = '{"html_url":"https://github.com/test/pull/1234"}'
+        pr_json = { 'html_url' => 'https://github.com/test/pull/1234' }
         url = "#{ENV['DANGER_JIRA_URL']}/rest/api/2/issue/WEB-134/remotelink"
         json = File.read("#{File.dirname(__FILE__)}/support/remotelink.json")
         issue = plugin.api.Issue.build