fix: iOS Timeout is broken because of Double miss conversion #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print(500 / 1000) -> 0 print(Double(500 / 1000)) -> 0.0 print(500 / Double(1000)) -> 0.5
|
Little wish : Can you after merging this PR release a new version on pub.dev ? |
navaronbracke
approved these changes
Nov 21, 2023
|
I'll release a new version with this fix tomorrow. |
|
@EArminjon Version 3.5.3 is now available on pub.dev. Thank you for your contribution! |
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
fix: iOS Timeout is broken because of Double miss conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Double conversion is broken leading to an Int round result.
(You can quickly check that here : https://online.swiftplayground.run/)
Important bug :).