Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check canAddInput for AVCaptureSession #1309

Conversation

navaronbracke
Copy link
Collaborator

Per the docs of addInput :

It’s only valid to call this method if canAddInput returns true.

https://developer.apple.com/documentation/avfoundation/avcapturesession/addinput(_:)

Fixes #1297

@navaronbracke navaronbracke changed the title Fix: check canAddInput for AVCaptureSession fix: check canAddInput for AVCaptureSession Jan 28, 2025
@juliansteenbakker
Copy link
Owner

Looks good! LGTM!

@juliansteenbakker juliansteenbakker merged commit 7b7a09e into juliansteenbakker:develop Feb 4, 2025
4 checks passed
@navaronbracke navaronbracke deleted the fix_avdevice_input_check branch February 4, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Exception: NSInvalidArgumentException
2 participants