Fix "Menu Open Start Press" for 2/3 speed #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the Ultimate Training Modpack, trying hold the (+) button to open the modpack menu will fail when
Speedis set to2/3in training mode.This PR changes the logic for how the (+) input is processed, in order to fix this issue.
Unlike
1/2and1/4speed, the2/3speed is not a cleanly divisible framerate. As a result, it is necessary to wait for 2 consecutive frames that the (+) button is known to have been released. This is necessary in order to prevent inputs from being processed incorrectly. Until 2 consecutive frames have passed, we're not sure if the user actually released the button, (as we often overwrite the (+) button press in the logic of the code itself)