Unit test fixes to support CAN mapping fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test_vcu unit test to follow recent evolution of CAN and libopencm3 interface changes. Update the Makefile to reflect the current names of the CTRL_xxx defines and add the new GITHUB_RUN_NUMBER define. Ensure that the GitHub Action builds and runs the unit tests again. Tests: - Build and run the updated unit tests demuddle CI changes
To allow more than one unit test that accesses the CAN hardware move the stub implementation into its own module. Tests: - Run the updated unit tests
For a wide variety of little/big-endian, offsets and
lengths verify that mapping these into a CAN frame
results in the expected contents.
Tests:
- Verify many failures are reported, clearly when
running the current libopeninv
- Verify no failures with the fixes in libopeninv PR#18
For a wide variety of little/big-endian, offsets and
lengths verify that mapping a parameter from a CAN frame results in the expected contents.
Tests:
- Verify many failures are reported, clearly when
running the current libopeninv
- Verify no failures with the fixes in libopeninv PR#18
When unit tests use std::hex to print failure information the line numbers printed by the ASSERT() macro are printed in hex as well. This is less than helpful so ensure they are always printed in decimal.
Validate all of the different ways it is possible to
incorrectly specify a can mapping through the "can tx"
or "can rx" command with a unit test.
Tests:
- Verify many failures are reported, clearly when
running the current libopeninv
- Verify no failures with the fixes in libopeninv PR#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of unit test improvements to cover the work in libopeninv covered by PR#18.
This will cause builds to fail until the libopeninv PR is merged and the project updated to use it.