Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(regex): Add support for pluggable regex engines for use in evaluation #491

Merged

Conversation

maxwellgerber
Copy link
Contributor

Motivation:
I would like to use JSONata with node-re2 - a regex node.js implementation that guards against backtracking.
This - in combination with work like #478 - will make it easier for me to run user-supplied JSONata in a sandbox.

The specific attack I'm looking to guard against is an ReDoS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b2ccd75 on maxwellgerber:feat/pluggable-regex into 68346a6 on jsonata-js:master.

@andrew-coleman andrew-coleman merged commit 2971f85 into jsonata-js:master Nov 17, 2020
@andrew-coleman
Copy link
Member

👍 thanks

@maxwellgerber maxwellgerber deleted the feat/pluggable-regex branch November 17, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants