Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#91 Motivate alternatives #96

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Conversation

anatoly-scherbakov
Copy link
Contributor

@anatoly-scherbakov anatoly-scherbakov commented Apr 21, 2023

@anatoly-scherbakov anatoly-scherbakov self-assigned this Apr 21, 2023
@anatoly-scherbakov anatoly-scherbakov force-pushed the issue-91-motivate-alternatives branch from 7f86eed to 1982876 Compare April 21, 2023 18:54
@anatoly-scherbakov anatoly-scherbakov changed the base branch from main to issue-91-extended-profile-alternatives April 21, 2023 19:11
Base automatically changed from issue-91-extended-profile-alternatives to main April 21, 2023 19:51
@anatoly-scherbakov anatoly-scherbakov force-pushed the issue-91-motivate-alternatives branch from 1982876 to 5a795a4 Compare April 21, 2023 19:53
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to merge, with consideration to my comment.

<li>Extended Internal Representation</li>
<li>
Preprocessor to convert an Extended YAML-LD document
to a plain YAML-LD document
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to define this better. Would that be a YAML-LD document sticking to the YAML JSON profile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'd suggest we do that in another PR. Created issue #97 for that purpose.

@anatoly-scherbakov anatoly-scherbakov merged commit 55f1085 into main Apr 22, 2023
@anatoly-scherbakov anatoly-scherbakov deleted the issue-91-motivate-alternatives branch April 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants