Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu22.04 support #626

Merged
merged 32 commits into from
Nov 12, 2024
Merged

ubuntu22.04 support #626

merged 32 commits into from
Nov 12, 2024

Conversation

sugikazu75
Copy link
Member

@sugikazu75 sugikazu75 commented Oct 12, 2024

What is this

This PR support this and related repositry on ubnutu22.04.

Details

We use ROS-O for ROS1 on ubuntu22.04.
Rostest by github action on docker image ubuntu-22.04 is passed.

TODO

To run with real machine we have to support following packages

  • rosserial
  • mocap_optitrack

rosdep install error in some package is happning because they are still not supported in ROS-O. Currently, we are ignoring error in rosdep install because they are not necessary to build package aerial_robot

PR list

@tongtybj
Copy link
Collaborator

tongtybj commented Oct 12, 2024

Amazing!

Let's try with real machine.

@sugikazu75
Copy link
Member Author

sugikazu75 commented Oct 12, 2024

roslaunch spinal bridge.launch was successed in docker container.
I will share Dockerfile wihtin a few days

@tongtybj
Copy link
Collaborator

Perfect!

@tongtybj
Copy link
Collaborator

One thing that I just realize is that ros-one-desktop-full might be not supported in Arch64 (for VIM4) yet.

@sugikazu75 sugikazu75 changed the title [GA] ubuntu22.04 support (only simulation) [GA] ubuntu22.04 support Oct 12, 2024
@sugikazu75 sugikazu75 changed the title [GA] ubuntu22.04 support ubuntu22.04 support Oct 13, 2024
@Li-Jinjie
Copy link
Collaborator

Is it possible to build the ROS Noetic from source on Ubuntu 22.04?

@sugikazu75
Copy link
Member Author

Is it possible to build the ROS Noetic from source on Ubuntu 22.04?

Yes it is possible.
Actually, ros-one-desktop-full is built on ubuntu-22.04 docker image and released.
Some packages can use the same sources as noetic, while others require patches.

@tongtybj
Copy link
Collaborator

tongtybj commented Nov 3, 2024

@sugikazu75 Have you tried mocap with real machine?

@sugikazu75
Copy link
Member Author

@sugikazu75 Have you tried mocap with real machine?

Yes. I confirmed that it works well when I built mocap_optitrack from source in a docker container.
I will check later using packages released by apt.

@tongtybj
Copy link
Collaborator

tongtybj commented Nov 3, 2024

@sugikazu75

For the mocap system in 0066, we have to use a modified branch developed by @Li-Jinjie : ros-drivers/mocap_optitrack#83

So, we don't need to use the packages released by apt for now.

@sugikazu75
Copy link
Member Author

sugikazu75 commented Nov 3, 2024

I forgot that some people have to use that branch. If we use that branch, I think we need more patches equivalent to ros-drivers/mocap_optitrack#87 to build on 22.04.
BTW, if we are not using apt-released package, should I add it to rosinstall?

@tongtybj
Copy link
Collaborator

tongtybj commented Nov 3, 2024

Yes, you are right. We have to combine ros-drivers/mocap_optitrack#83, ros-drivers/mocap_optitrack#84, ros-drivers/mocap_optitrack#87 into one branch.
And yes, we need to add to the rosinstall list.

@sugikazu75
Copy link
Member Author

I checked mocap is working on 22.04 with sugikazu75/mocap_optitrack#1
I updated rosinstall for 22.04. And I created #632 for other distros.

@tongtybj tongtybj self-requested a review November 12, 2024 10:13
@tongtybj
Copy link
Collaborator

@sugikazu75

We have achieved a very important progress for the continuous development.

Thank you!

@tongtybj tongtybj merged commit 71d746f into jsk-ros-pkg:master Nov 12, 2024
6 checks passed
@sugikazu75
Copy link
Member Author

This PR supports this and related repositry on ubuntu 22.04 using ROS-O.

@ For all developers
Currently, ROS1 for ubuntu22.04 is built and released from my repositry (https://github.com/sugikazu75/ros-o-builder), which is public fork of https://github.com/v4hn/ros-o-builder.
This CI process is executed once a week (refer to https://github.com/sugikazu75/ros-o-builder/blob/fee16e0d0b1951117d1ae0802252d44cd7dd1e18/.github/workflows/build.yaml#L7).

If you want some packages to be released, please tell me package name, github URL, and commit hash. Or directly create PR to https://github.com/sugikazu75/ros-o-builder like as v4hn/ros-o-builder@build-for-jammy...sugikazu75:ros-o-builder:build-for-jammy .

@sugikazu75 sugikazu75 deleted the GA/jammy branch November 12, 2024 14:07
Li-Jinjie pushed a commit to Li-Jinjie/jsk_aerial_robot_dev that referenced this pull request Dec 13, 2024
* [GA] add github action for jammy using ROS-O

* update

* update

* ubnutu:jammy

* ubnutu-22.04

* [GA] setup ros workspace and catkin build

* [GA] noetic->one

* [GA] python3-wstool

* [GA] sudo apt install python3-wstool

* [spinal] cmake17

* add rosinstall for debian. modified from noetic one

* update rosinstall path

* fix typo

* [motor test] C++17

* [GA] catkin build only aerial_robot and run catkin test

* skip libgeographiclib-dev

* [GA] ignore rosdep install error temporality

* [ROS-O][rosinstall] use C++17 patched mocap_optitrack package (#13)

* [ROS-O][rosinstall] update external repository path and version (jsk-ros-pkg#15)

* use self released apt repository

* update external repositry version

* remove external repositry from rosinstall because they are released

* remove error ignore flag when rosdep install

* [mocap_optitrack] add mocap_optitrack package to rosinstall

* [ROS-O][GA] build all packages

* [CI] remove the script for EoL ros distribution

* [CI][GA] merge ros one distribution test into .travis.sh

* [ROS-O] crate configure script to install ros-o system for jammy

* [ROS-O] update REAMDE to show the install instruction on Ubuntu22.04

* fix typo in README

* [rosinstall] remove rosinstall for EoL distribution

---------

Co-authored-by: Moju Zhao <[email protected]>
Co-authored-by: Moju Zhao <[email protected]>

(cherry picked from commit 71d746f)
@Li-Jinjie
Copy link
Collaborator

My MPC branch is also updated to support ubuntu22.04 and ROS-O: https://github.com/Li-Jinjie/jsk_aerial_robot_dev/tree/develop/MPC_tilt_mt/robots/beetle#beetle-art-omni

Thank you for implementing this function!

tongtybj added a commit to tongtybj/aerial_robot that referenced this pull request Jan 27, 2025
* [GA] add github action for jammy using ROS-O

* update

* update

* ubnutu:jammy

* ubnutu-22.04

* [GA] setup ros workspace and catkin build

* [GA] noetic->one

* [GA] python3-wstool

* [GA] sudo apt install python3-wstool

* [spinal] cmake17

* add rosinstall for debian. modified from noetic one

* update rosinstall path

* fix typo

* [motor test] C++17

* [GA] catkin build only aerial_robot and run catkin test

* skip libgeographiclib-dev

* [GA] ignore rosdep install error temporality

* [ROS-O][rosinstall] use C++17 patched mocap_optitrack package (jsk-ros-pkg#13)

* [ROS-O][rosinstall] update external repository path and version (jsk-ros-pkg#15)

* use self released apt repository

* update external repositry version

* remove external repositry from rosinstall because they are released

* remove error ignore flag when rosdep install

* [mocap_optitrack] add mocap_optitrack package to rosinstall

* [ROS-O][GA] build all packages

* [CI] remove the script for EoL ros distribution

* [CI][GA] merge ros one distribution test into .travis.sh

* [ROS-O] crate configure script to install ros-o system for jammy

* [ROS-O] update REAMDE to show the install instruction on Ubuntu22.04

* fix typo in README

* [rosinstall] remove rosinstall for EoL distribution

---------

Co-authored-by: Moju Zhao <[email protected]>
Co-authored-by: Moju Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants