Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gp: fix tooltips positions on mobile screens #721

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

xbpcb
Copy link
Collaborator

@xbpcb xbpcb commented Jan 7, 2025

Also, apply unified styles for all GP tooltips

Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positioning is better, but the padding should stay as it was on short tooltips (even if there's a change they'll break in two lines). Only those that originally had the multiple attribute should have the bigger padding.

@MartinKolarik MartinKolarik temporarily deployed to gp-mobile-tooltip-fix - globalping.io PR #721 January 9, 2025 15:12 — with Render Destroyed
@jimaek jimaek temporarily deployed to gp-mobile-tooltip-fix - www.jsdelivr.com PR #721 January 9, 2025 15:12 — with Render Destroyed
@MartinKolarik MartinKolarik merged commit af26ef9 into master Jan 9, 2025
1 check passed
@MartinKolarik MartinKolarik deleted the gp-mobile-tooltip-fix branch January 9, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants