Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more extras #1

Open
wants to merge 1 commit into
base: v8.13
Choose a base branch
from
Open

Adding more extras #1

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link

This is my wishlist for mathcomp extra packages (untested)

This is my wishlist for mathcomp extra packages (untested)
@corwin-of-amber
Copy link
Member

Oh cool! Of course for actually having them they need to be added to the Makefile as well, and we need to see that they compile. I assume at least they all have 8.14-compatible versions by now?

@CohenCyril
Copy link
Author

I assume at least they all have 8.14-compatible versions by now?

I also assume so. (I manually checked by I cannot tell for sure since I do not use opam)

@corwin-of-amber
Copy link
Member

Do you know if they have Dune build files? This would make integration very easy.

@ejgallego
Copy link
Member

Do you know if they have Dune build files? This would make integration very easy.

I can write the dune files, where's the repos?

@CohenCyril
Copy link
Author

@CohenCyril
Copy link
Author

none of them have dune build files

@ejgallego
Copy link
Member

none of them have dune build files

Ok thanks, I'll add them as PRs

@CohenCyril
Copy link
Author

(BTW all of these should work perfectly with any combination of Coq 8.13 or Coq 8.14 and mathcomp 1.12 and 1.13)

@CohenCyril
Copy link
Author

Note that for mathcomp analysis you will need hierarchy-builder as well

https://github.com/math-comp/hierarchy-builder 1.2.0

@ejgallego
Copy link
Member

ejgallego commented Dec 3, 2021

Note that for mathcomp analysis you will need hierarchy-builder as well

Ups, that may go beyond the amount of time I have for it :( :(

All these plugins are, IMHO, an engineering nightmare.

@CohenCyril
Copy link
Author

Then take out mathcomp analysis for now.

@corwin-of-amber
Copy link
Member

Oh oops looks like we totally forgot about this little thing. Do you want to rebase for 8.16? sry... 😞

@corwin-of-amber
Copy link
Member

actually I see now this is just a list. We need to revisit these packages; if they are a part of coq-universe this should be easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants