Bugfix/enable teams message failed builds

README.md

@@ -46,10 +46,10 @@ After preparation of your local environment the script will execute the jscm com
 
 It will execute both possible command:
 
-- teams-develop (in failed/successful state)
-- teams-production (in failed/successful state)
+- teams-develop (in failed/successful state/without artifacts)
+- teams-production (in failed/successful state/without artifacts)
 
-→ This will result in 4 messages being sent to the specified teams channel
+→ This will result in 4(2 failed/2 successful) messages being sent to the specified teams channel as well as 2 exceptions exceptions.
 
 ### Calling the test script
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@js-soft/codemagic-tools",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Codemagic extended tooling",
   "homepage": "https://github.com/js-soft/codemagic-tools#readme",
   "bugs": {

src/index.ts

@@ -3,7 +3,7 @@
 import fs from "fs";
 import os from "os";
 import yargs from "yargs";
-import { CmArtifactLink } from "./CmArtifactLink";
+
 import { TeamsCommandLineOptions } from "./commands/TeamsCommandLineOptions";
 import { runTeamsDevelopMessagingCommand } from "./commands/TeamsDevelopMessaging";
 import { runTeamsProductionMessagingCommand } from "./commands/TeamsProductionMessaging";
@@ -17,24 +17,27 @@ async function run() {
   const buildNumber = parseInt(process.env.BUILD_NUMBER!);
   const buildUrl = `https://codemagic.io/app/${projectId}/build/${buildId}`;
 
-  if (process.env.CM_ARTIFACT_LINKS === undefined) {
-    console.error(
-      "To ensure correct execution the environment variable CM_ARTIFACT_LINKS must be present in the system"
-    );
-    process.exit(1);
-  }
-
   let artifactUrl: string;
   let artifactType: string;
 
-  const cmArtifactLinks: CmArtifactLink[] = JSON.parse(process.env.CM_ARTIFACT_LINKS!).filter(
-    (element: any) => element.type === "apk" || element.type === "ipa"
-  );
-  if (cmArtifactLinks.filter((element: any) => element.type === "apk" || element.type === "ipa").length !== 0) {
-    const pickedElement = cmArtifactLinks.filter((element: any) => element.type === "apk" || element.type === "ipa")[0];
-    artifactUrl = pickedElement.url;
-    artifactType = pickedElement.type;
+  let failedState = false;
+
+  if (process.env.CM_ARTIFACT_LINKS === undefined) {
+    failedState = true;
   } else {
+    const cmArtifactLinks = JSON.parse(process.env.CM_ARTIFACT_LINKS);
+    if (cmArtifactLinks.filter((element: any) => element.type === "apk" || element.type === "ipa").length === 0) {
+      failedState = true;
+    } else {
+      const pickedElement = cmArtifactLinks.filter(
+        (element: any) => element.type === "apk" || element.type === "ipa"
+      )[0];
+      artifactUrl = pickedElement.url;
+      artifactType = pickedElement.type;
+    }
+  }
+
+  if (failedState) {
     // should link to the workflow-log can be determined from buildId and projectId
     artifactUrl = buildUrl;
     artifactType = "logs";
@@ -80,14 +83,23 @@ async function run() {
       () => {
         return;
       },
-      async (args) =>
+      async (args) => {
+        if (failedState) {
+          console.log("Cannot send production message for a build, which did not produce an artifact.");
+          process.exit(1);
+        }
+        if (!buildWasSuccessful) {
+          console.log("Cannot send production message for failed build.");
+          process.exit(1);
+        }
         await runTeamsProductionMessagingCommand({
           projectName: args.projectName,
           platform: args.platform,
           buildUrl,
           buildNumber,
           webhook
-        })
+        });
+      }
     )
     .demandCommand(1, "Must provide a valid command from the ones listed above.")
     .scriptName("jscm")

test/test_teams_messaging.sh

@@ -17,11 +17,18 @@ echo "Enter the BUILD_NUMBER  :"
 read BUILD_NUMBER_VALUE
 export BUILD_NUMBER=$BUILD_NUMBER_VALUE
 
-export CM_ARTIFACT_LINKS=$(cat artifactLinks.json)
+# we want to test the execution without any artifacts present
+echo "Testing without the artifactLinks environment variable"
+jscm teams-develop --platform "ios" --projectName "Mein Codemagic Test Projekt"
+jscm teams-production --platform "ios" --projectName "Mein Codemagic Test Projekt"
+echo "Finished teams messaging tests without artifactLinks"
 
-echo "webhook url: $teams_webhook_url"
+echo "--------------------------------------------"
+export CM_ARTIFACT_LINKS=$(cat artifactLinks.json)
+echo "created the artifactLinks environment variable"
+echo "--------------------------------------------"
 
-echo "Starting teams messaging tests"
+echo "Testing with the artifactLinks environment variable"
 jscm teams-develop --platform "ios" --projectName "Mein Codemagic Test Projekt"
 jscm teams-production --platform "ios" --projectName "Mein Codemagic Test Projekt"
 touch ~/SUCCESS