Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in DBAPI 2 documentation #1251

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Pebble94464
Copy link
Contributor

Fixes about 45 typos in the documentation for DBAPI 2.

Please note line 293 contains a link to 'Cursor.use', which doesn't appear to exist. Please advise.
A comment on line 295 that I added about the broken link can be deleted.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.19%. Comparing base (29cce31) to head (e5a1083).
Report is 44 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         113      113           
  Lines       10296    10296           
  Branches     4051     4051           
=======================================
  Hits         8978     8978           
  Misses        726      726           
  Partials      592      592           
Files with missing lines Coverage Δ
jpype/dbapi2.py 94.35% <ø> (ø)

@pelson
Copy link
Contributor

pelson commented Jan 13, 2025

Hi @Pebble94464, thanks for taking the time to improve the docs. All looks good to me 👍

@Thrameos Thrameos merged commit fa54bca into jpype-project:master Jan 20, 2025
24 checks passed
@Pebble94464 Pebble94464 deleted the fix-typos branch January 21, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants