Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XML generator class overridable #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidfischer-ch
Copy link

No description provided.

@jpadilla
Copy link
Owner

@davidfischer-ch thanks! A small test and update the docs would make this even better.

@davidfischer-ch
Copy link
Author

Sure, I will !

@kyleobrien91
Copy link
Collaborator

@davidfischer-ch - stil interested in making those small changes so we can merge this?

  • add a test
  • add some coverage about this in the documentation

@davidfischer-ch
Copy link
Author

Hello,

Unfortunately I didn't have time to do so, but this "design pattern" is so common in the Python world ... Is it really needed to write test and doc?

Thanks.

@jkblume
Copy link

jkblume commented Jul 16, 2018

Hello :)

really want to push this PR. I'm pretty much at the same position and need to override the short_empty_elements flag on XMLGenerator initialization.

Is it possible to support you on brining this PR fast into master? :)

Copy link

@jkblume jkblume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very tiny and neat change, with good effort

@davidfischer-ch
Copy link
Author

Hello,

I just resolved the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants