-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make XML generator class overridable #9
base: master
Are you sure you want to change the base?
Conversation
@davidfischer-ch thanks! A small test and update the docs would make this even better. |
Sure, I will ! |
@davidfischer-ch - stil interested in making those small changes so we can merge this?
|
Hello, Unfortunately I didn't have time to do so, but this "design pattern" is so common in the Python world ... Is it really needed to write test and doc? Thanks. |
Hello :) really want to push this PR. I'm pretty much at the same position and need to override the Is it possible to support you on brining this PR fast into master? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very tiny and neat change, with good effort
Hello, I just resolved the conflict. |
No description provided.