README fix & WebMock tweaks #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Not sure why RSpec failed all that time ago on a text change but I tried it again in separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for your hard work on this project.
I noticed a small change to the README that appears to have been missed on the (80bff95) commit. When I ran the test I was getting
WebMock::NetConnectNotAllowedErrorerrors. So I've also committed the tweaks that got the specs passing for me. (Please forgive my novice comprehension of WebMock if those changes are in error.)Finally, please consider adding a small "Development Setup" (or the like) in the README. For example:
Development Setup
Here's all you'll need to get up and running for local development:
Thanks again!