Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make compilable with ratatui 0.29 #43

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

p0kR
Copy link
Contributor

@p0kR p0kR commented Oct 23, 2024

To make the crates compatible with Ratatui 0.28 and 0.29, I changed to ">=0.28". Feel free to change this, if you don't like it.

Additionally, two example were invalid and failed when calling cargo test --all. I fixed those.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (7be6cd3) to head (241cf18).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #43   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines        150     150           
=====================================
  Misses       150     150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka
Copy link
Owner

joshka commented Oct 25, 2024

To make the crates compatible with Ratatui 0.28 and 0.29, I changed to ">=0.28". Feel free to change this, if you don't like it.

Unfortunately due to the way that cargo evaluates versions, this really means compile with 0.29, which causes failures for apps which have not yet bumped to 0.29 themselves. The right way for now is to bump all the versions when releasing like my changes in this have done. We're going to fix the need for this in the next Ratatui release by moving widgets into a ratatui-widgets crate, and the core things into a slower changing ratatui-core crate. This should cause no problems for apps, and should be easy for widget crates to switch to. See ratatui/ratatui#1388 for more details.

@joshka joshka merged commit e65caad into joshka:main Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants