Set file mode to 0444 instead of 0666 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine I guess, but are there any circumstances in which it actually matters? |
Set file mode to 0444 as txtar is a read-only fileformat, and in general the io/fs.FS API doesn't allow to modify files.
dolmen
force-pushed
the
change-perms-to-readonly
branch
from
256742e to
009d3e7
Compare
A client of the io/fs.FS API might use different strategies for caching file data based on the FileMode: a file marked readonly might be considered as never changing, so not needing a reload after the first read. Does it applies in cases where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set file mode to
0444(r--r--r--) as txtar is a read-only fileformat, and in general theio/fs.FSAPI doesn't allow to modify files.