Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming Client Result investigation - assistants #46

Conversation

annelo-msft
Copy link
Collaborator

Poking at it to learn

hallipr and others added 23 commits March 18, 2024 10:49
* Upload the nuget package as a release asset
* Remove workflow_dispatch trigger from release
* Use `published` type for release event triggering
* Add contents: write permission to release workflow
* Added `ModifyMessage` and `ModifyMessageAsync` protocol and convenience methods to `AssistantClient`.
* Fixed typo: `GetAssistantFileAssociation` --> `GetAssistantFileAssociations`
* Fixed typo: `GetAssistantFileAssociationAsync` --> `GetAssistantFileAssociationsAsync`
* Added missing usages of `ConfigureAwait(false)` in `AssistantClient`.
* Add convenience methods for image edits and variations

* investigation

* WIP

* rework to depend on local implementation of ClientModel

* go back to using BCL type

* WIP

* WIP

* file client

* update for filename

* Add model implementation prototype

* backup WIP

* unlink demo client

* refactor

* move content creation routine to model

* null

* revert

* cleanup

* revert

* Add clean generated client using System.ClientModel 1.0.0-beta.2

* delete files not used for diff

* move to public clientmodel package

* Create transcription

* Create translation

* tidy

* tidy

* Add Stream overloads for audio service methods

* file endpoints

* nits

* nits

* image edits

* image variations

* nits

* stream overloads for file upload

* stream overloads for image operations

* nits

* update for Content-Length

* rework file name APIs

* rework file name APIs

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

* Update from @joseharriaga

Co-authored-by: Jose Arriaga Maldonado <[email protected]>

---------

Co-authored-by: Jose Arriaga Maldonado <[email protected]>
Co-authored-by: Jose Arriaga Maldonado <[email protected]>
…ent (#17)

* polyfill ExperimentalAttribute and use it for AssistantClient

* polyfill update from source, parallel #if directive

* PR feedback
* basics for moving ImageSize to a non-enum type

* update named static readonly sizes per Jose's proposal
…r APIView feedback (#41)

This PR updates audio, file, and image service methods that use the multipart/form-data content type on requests.

It includes the following:
- Removes BinaryData overloads of these service methods, in favor of Stream overload -- this is so users don't inadvertently load large binary content into memory by calling the wrong overload with a large file.
- Adds FileStream overloads for a bit of convenience when a file is opened from disk -- so users don't have to pass the file name in two places.
- Updates some output APIs that were returning BinaryData that could possibly be large files to return Streams instead.
@trrwilson trrwilson deleted the branch joseharriaga:user/traviw/streaming-assistants May 17, 2024 09:30
@trrwilson trrwilson closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants