-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tsserver-deprecation): use ts_ls where tsserver is being used in lspconfig #89
base: main
Are you sure you want to change the base?
Conversation
@josean-dev @RigottiG @MarkCodesTheWeb @aspehler @kannicht @pieterjan84 @santiagohervella @s4Dt0y |
If the problem resides in the fact that lspconfig renamed -- default handler for installed servers
function(server_name)
lspconfig[server_name].setup({
capabilities = capabilities,
})
end,
-- mason still installs `tsserver`
["tsserver"] = function()
-- lspconfig sees `ts_ls`
lspconfig["ts_ls"].setup({
capabilities = capabilities,
...
end, The result of vim.lsp: require("vim.lsp.health").check()
- LSP log level : WARN
- Log path: /Users/Mccranky/.local/state/nvim/lsp.log
- Log size: 9460 KB
vim.lsp: Active Clients ~
- ts_ls (id: 1)
Root directory: nil
Command: /Users/Mccranky/.local/share/nvim/mason/bin/typescript-language-server --stdio
Settings: vim.empty_dict()
Attached buffers: 1
- emmet_ls (id: 2)
Root directory: nil
Command: /Users/Mccranky/.local/share/nvim/mason/bin/emmet-ls --stdio
Settings: vim.empty_dict()
Attached buffers: 1
- copilot (id: 3)
Command: node /Users/Mccranky/.local/share/nvim/lazy/copilot.lua/copilot/index.js
Settings: {
advanced = {
inlineSuggestCount = 3,
listCount = 10
}
}
Attached buffers: 1, 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the change. I'm still getting ERROR -
- Pasted the contents of the modified file as is.
- Ran the provided reload command
- Restarted nvim
- Observed same issue.
[mason-lspconfig.nvim] Server "tsserver" is not a valid entry in ensure_installed. Make sure to only p
rovide lspconfig server names.
"tsserver", |
changing this to
ts_ls
worked.
This PR addresses the following error when opening nvim:
"tsserver is deprecated, use ts_ls instead. Feature will be removed in lspconfig 0.2.0"
The issue was raised here:
#88
The solution was given here:
neovim/nvim-lspconfig#3232 (comment)
Note that you may need to do a reload of the related plugins:
:Lazy reload mason.nvim mason-lspconfig.nvim mason-tool-installer.nvim