This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Adding new constructor for MutableListArray #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
- Coverage 83.58% 83.43% -0.15%
==========================================
Files 388 388
Lines 41912 42010 +98
==========================================
+ Hits 35034 35053 +19
- Misses 6878 6957 +79
☔ View full report in Codecov by Sentry. |
sundy-li
reviewed
Jun 8, 2023
cjermain
commented
Jun 20, 2023
| validity: Option<MutableBitmap>, | ||
| ) -> Self { | ||
| assert_eq!(values.len(), offsets.last().to_usize()); | ||
| let data_type = values.data_type().clone(); |
There was a problem hiding this comment.
@sundy-li, thanks for the quick response. Unfortunately I missed on the dtype -- it should be the following:
let data_type = ListArray::<O>::default_datatype(values.data_type().clone());
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1502 by introducing a new constructor for
MutableListArraythat allows for building an object based on existing values from aMutableArray,Offsets, andMutableBitmap. I'm interested in feedback on this relative to the question posed in #1502, and happy to add tests if this seems like the right approach.