Enable install command on Windows #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Compare the kernel name string in lower case 2. Use the `bsdtar` command on Windows, because it can extract ZIP files
jorgebucaran
reviewed
Dec 5, 2024
| @@ -114,7 +116,7 @@ function nvm --description "Node version manager" | |||
| end | |||
|
|
|||
| if ! command curl -q $silent --progress-bar --location $url | | |||
| command tar --extract --gzip --directory $nvm_data/$ver 2>/dev/null | |||
| command $tarcmd --extract --gzip --directory $nvm_data/$ver 2>/dev/null | |||
There was a problem hiding this comment.
Do you happen to remember which version of Fish started supporting this way of running a command?
There was a problem hiding this comment.
Are you asking about the command builtin or using variable expansion for the program name? I believe both have been present since the first release of Fish.
There was a problem hiding this comment.
@jorgebucaran Is there anything else needed before you can merge this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsdtarcommand on Windows because it can extract ZIP files