-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding #42: Add options.array #43
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 94 95 +1
=====================================
+ Hits 94 95 +1
Continue to review full report at Codecov.
|
Great work, @ianwalter! I'm going to run this through the benchmark before I make a decision. Thanks! |
@ianwalter Mind sharing your benchmark results? :) |
On
|
@ianwalter Do you think you can update |
Sorry, was on vacation and forgot about this. Will update it now. |
Hey @jorgebucaran, could we merge this? |
@ndabAP Docs are still missing (I did forget to request them, though). Let me see if I can manage to write them this week or over the weekend and merge this once and for all! 💯 |
@ianwalter @ndabAP To clarify, this feature lets you specify which options must be treated as arrays, but we're still making arrays from repeated options anyway. The difference is you'd need to check if that option was an array or not yourself before trying to access it. Is this the desired behavior? |
#42