Refactors

jordanmontt · Feb 20, 2024 · 32fa768 · 32fa768
1 parent 4ffe1bc
commit 32fa768
Show file tree

Hide file tree

Showing 8 changed files with 100 additions and 172 deletions.
diff --git a/...-Tests/IllAllocationProfilerTest.class.st → ...ts/IllAllocationSiteProfilerTest.class.st b/...-Tests/IllAllocationProfilerTest.class.st → ...ts/IllAllocationSiteProfilerTest.class.st
@@ -1,23 +1,23 @@
 Class {
-	#name : 'IllAllocationProfilerTest',
+	#name : 'IllAllocationSiteProfilerTest',
 	#superclass : 'IllAbstractProfilerTest',
 	#category : 'IllimaniProfiler-Tests-Allocations-Profiler',
 	#package : 'IllimaniProfiler-Tests',
 	#tag : 'Allocations-Profiler'
 }
 
 { #category : 'running' }
-IllAllocationProfilerTest >> profilerClass [
+IllAllocationSiteProfilerTest >> profilerClass [
 
-	^ IllAllocationProfiler
+	^ IllAllocationSiteProfiler
 ]
 
 { #category : 'tests' }
-IllAllocationProfilerTest >> testProfileOnCopyExecutionStack [
+IllAllocationSiteProfilerTest >> testProfileOnCopyExecutionStack [
 
 	profiler
 		copyExecutionStack;
-		profileOn: [ 10 timesRepeat: [ IllAllocationProfiler new ] ].
+		profileOn: [ 10 timesRepeat: [ IllAllocationSiteProfiler new ] ].
 
 	"Take one random allocation to check"
 	self assert: profiler objectAllocations last context class equals: Context.
@@ -28,7 +28,7 @@ IllAllocationProfilerTest >> testProfileOnCopyExecutionStack [
 ]
 
 { #category : 'tests' }
-IllAllocationProfilerTest >> testProfileOnSimpleMoreAllocations [
+IllAllocationSiteProfilerTest >> testProfileOnSimpleMoreAllocations [
 
 	profiler profileOn: [ 1000 timesRepeat: [ self profilerClass new ] ].
 

diff --git a/src/IllimaniProfiler/AllocationBasicInfoModel.class.st b/src/IllimaniProfiler/AllocationBasicInfoModel.class.st
diff --git a/src/IllimaniProfiler/AllocationFinalizationInfoModel.class.st b/src/IllimaniProfiler/AllocationFinalizationInfoModel.class.st
diff --git a/src/IllimaniProfiler/AllocationSiteInfoModel.class.st b/src/IllimaniProfiler/AllocationSiteInfoModel.class.st
@@ -1,17 +1,32 @@
 Class {
 	#name : 'AllocationSiteInfoModel',
-	#superclass : 'AllocationFinalizationInfoModel',
+	#superclass : 'Object',
 	#instVars : [
+		'allocatedObjectClass',
+		'sizeInBytes',
 		'context',
 		'allocatorMethod',
 		'allocatorClass',
-		'contextFingerprint'
+		'contextFingerprint',
+		'initializationTime'
 	],
-	#category : 'IllimaniProfiler-Model-Allocation',
+	#category : 'IllimaniProfiler-Allocation-Profiler',
 	#package : 'IllimaniProfiler',
-	#tag : 'Model-Allocation'
+	#tag : 'Allocation-Profiler'
 }
 
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> allocatedObjectClass [
+
+	^ allocatedObjectClass
+]
+
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> allocatedObjectClass: anObject [
+
+	allocatedObjectClass := anObject
+]
+
 { #category : 'accessing' }
 AllocationSiteInfoModel >> allocatorClass [
 
@@ -77,15 +92,48 @@ AllocationSiteInfoModel >> fullMethodName [
 	^ allocatorMethod name
 ]
 
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> initializationTime [
+	"In microseconds"
+
+	^ initializationTime
+]
+
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> initializationTime: microsecondsAsInt [
+	"In microseconds"
+
+	initializationTime := microsecondsAsInt
+]
+
 { #category : 'inspector - extensions' }
 AllocationSiteInfoModel >> inspectableAssociations [
 
 	^ super inspectableAssociations , {
+		  ('Allocated Object Class' -> allocatedObjectClass).
+		  ('Memory Size' -> sizeInBytes humanReadableByteSizeString).
+		  ('Initialization timestamp' -> initializationTime).
 		  ('Allocator Class' -> allocatorClass).
 		  ('Allocator Method' -> allocatorMethod).
 		  ('Context' -> context) }
 ]
 
+{ #category : 'inspector - extensions' }
+AllocationSiteInfoModel >> inspectorExtension: aBuilder [
+
+	<inspectorPresentationOrder: 0 title: 'Overview'>
+	| tablePresenter elements items |
+	elements := self inspectableAssociations.
+	items := elements collect: [ :e | StInspectorAssociationNode hostObject: e ].
+	tablePresenter := aBuilder newTable.
+	tablePresenter
+		addColumn: (SpStringTableColumn title: 'Name' evaluated: #key);
+		addColumn: (SpStringTableColumn title: 'Value' evaluated: #value);
+		items: items;
+		beResizable.
+	^ tablePresenter
+]
+
 { #category : 'inspector - extensions' }
 AllocationSiteInfoModel >> inspectorExtensionContextFingerprint: aBuilder [
 
@@ -101,3 +149,22 @@ AllocationSiteInfoModel >> printOn: aStream [
 	sizeInBytes ifNil: [ aStream << ' - ' ]
 		ifNotNil: [ aStream << sizeInBytes humanReadableByteSizeString ]
 ]
+
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> sizeInBytes [
+	"Returns the size in memory in bytes"
+
+	^ sizeInBytes
+]
+
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> sizeInBytes: aNumber [
+
+	sizeInBytes := aNumber
+]
+
+{ #category : 'accessing' }
+AllocationSiteInfoModel >> timeAsSeconds [
+
+	^ initializationTime / 1000000
+]
diff --git a/src/IllimaniProfiler/GCActivityMonitor.class.st b/src/IllimaniProfiler/GCActivityMonitor.class.st
@@ -7,9 +7,9 @@ Class {
 		'waitingTime',
 		'scavenges'
 	],
-	#category : 'IllimaniProfiler-Model-Statistics',
+	#category : 'IllimaniProfiler-GC-Monitor',
 	#package : 'IllimaniProfiler',
-	#tag : 'Model-Statistics'
+	#tag : 'GC-Monitor'
 }
 
 { #category : 'exporting' }