docker compose override #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- could work out how the string would be split into an array - modified the creation of the array so that spaces would be delimeter instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105
Joomlatools server certainly seems to provide for override files:
https://github.com/joomlatools/joomlatools-server/blob/master/.gitignore#L9
And the Joomlatools Control also can look for these files if provided in the correct format:
https://github.com/joomlatools/joomlatools-server/blob/master/.gitignore#L9
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl#L149-L158
Can't for the life of me, with the current code how to provide the list of docker compose files, that would be exploded into an array here:
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl#L149
So have modified for testing.
Testing
export SERVER_FILES="docker-compose.yml docker-compose.override.yml"sh bin/jtctl startdocker compose config