[5.3] Remove useless empty ($form) check #45039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomdonation
changed the title
QuyTon
reviewed
Feb 28, 2025
administrator/components/com_associations/src/Model/AssociationModel.php
Outdated
Show resolved
Hide resolved
voronkovich
reviewed
Feb 28, 2025
administrator/components/com_associations/src/Model/AssociationModel.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The
loadFormmethod fromFormBehaviorTrait(which is used by our models) always return aFormobject on success and throw Exception on failure, so all empty($form) check in our model classes are useless, it never returns false, thus should be moved from models code.Testing Instructions
This will require careful code review from our testers and maintainer.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, slight faster because the useless code is removed, thus not being executed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed