Added comments. Added old design standard PDFs.

jonsagara · Nov 20, 2024 · 592453b · 592453b
1 parent 50b49e9
commit 592453b
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 6 deletions.
diff --git a/docs/AAMVA-2000-DLID-Card-Design-Standard.pdf b/docs/AAMVA-2000-DLID-Card-Design-Standard.pdf
diff --git a/docs/AAMVA-2003-DLID-Card-Design-Standard.pdf b/docs/AAMVA-2003-DLID-Card-Design-Standard.pdf
diff --git a/docs/AAMVA-2005-DLID-Card-Design-Standard.pdf b/docs/AAMVA-2005-DLID-Card-Design-Standard.pdf
diff --git a/docs/AAMVA-2010-DLID-Card-Design-Standard.pdf b/docs/AAMVA-2010-DLID-Card-Design-Standard.pdf
diff --git a/global.json b/global.json
@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.200",
+    "version": "8.0.404",
     "rollForward": "latestPatch"
   }
 }
diff --git a/src/IdParser.Core/Fixes.cs b/src/IdParser.Core/Fixes.cs
@@ -12,11 +12,19 @@ internal static string TryToCorrectHeader(string rawPdf417Input, ILoggerFactory
     {
         var logger = loggerFactory.CreateLogger(typeof(Fixes));
 
-        return rawPdf417Input
-            .RemoveUndefinedCharacters()
-            .RemoveInvalidCharactersFromHeader(logger)
-            .FixIncorrectHeader(logger)
-            .RemoveIncorrectCarriageReturns(logger);
+        // This isn't easily debuggable.
+        //return rawPdf417Input
+        //    .RemoveUndefinedCharacters()
+        //    .RemoveInvalidCharactersFromHeader(logger)
+        //    .FixIncorrectHeader(logger)
+        //    .RemoveIncorrectCarriageReturns(logger);
+
+        rawPdf417Input = rawPdf417Input.RemoveUndefinedCharacters();
+        rawPdf417Input = rawPdf417Input.RemoveInvalidCharactersFromHeader(logger);
+        rawPdf417Input = rawPdf417Input.FixIncorrectHeader(logger);
+        rawPdf417Input = rawPdf417Input.RemoveIncorrectCarriageReturns(logger);
+
+        return rawPdf417Input;
     }
 
 

diff --git a/src/IdParser.Core/Parsers/Id/NameParser.cs b/src/IdParser.Core/Parsers/Id/NameParser.cs
@@ -2,6 +2,9 @@
 
 internal record NameParts(string? First, string? Middle, string? Last, string? Suffix);
 
+/// <summary>
+/// Name parser for legacy AAMVA 2000 spec. The field code doesn't appear in the 2020 spec.
+/// </summary>
 internal static class NameParser
 {
     private static readonly char[] StandardSeparators = { ',', '$', '@' };

diff --git a/src/IdParser.Core/Parsers/Parser.cs b/src/IdParser.Core/Parsers/Parser.cs
@@ -149,6 +149,7 @@ internal static ParseAndSetElementResult ParseAndSetIdCardElement(string element
                 break;
 
             case SubfileElementIds.Name:
+                // Name parser for legacy 2000 spec. The field code doesn't appear in the 2020 spec.
                 // NOTE: this parser doesn't report errors
                 var nameParts = NameParser.Parse(elementId: elementId, rawValue: rawValue);
                 idCard.FirstName = FieldHelpers.ParsedField(elementId: elementId, value: nameParts?.First, rawValue: rawValue);