Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write docs #113

Merged
merged 25 commits into from
Aug 31, 2022
Merged

Write docs #113

merged 25 commits into from
Aug 31, 2022

Conversation

jonodrew
Copy link
Owner

Once this is completed, users will be able to read how to download and run this software locally. They'll also be aware of all of the technical things I can think of.

@jonodrew jonodrew linked an issue Aug 20, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Aug 20, 2022

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.13-final-0 -----------

Name Stmts Miss Cover
/app/init.py 22 0 100%
/app/auth/init.py 3 0 100%
/app/auth/routes.py 17 2 88%
/app/classes.py 83 3 96%
/app/config.py 10 1 90%
/app/export.py 28 4 86%
/app/extensions.py 3 0 100%
/app/helpers.py 75 27 64%
/app/main/init.py 7 1 86%
/app/main/routes.py 128 14 89%
/app/notify/init.py 3 0 100%
/app/notify/routes.py 49 12 76%
/app/tasks/init.py 10 2 80%
/app/tasks/helpers.py 11 4 64%
/app/tasks/tasks.py 40 2 95%
TOTAL 489 72 85%
======================= 41 passed, 66

@jonodrew
Copy link
Owner Author

@johnpeart can you docker-compose up this locally, and tell me if you can see the docs? Should be on localhost:4000

@johnpeart
Copy link
Collaborator

@johnpeart can you docker-compose up this locally, and tell me if you can see the docs? Should be on localhost:4000

Yes I do! Cool that it runs both at once!

@johnpeart
Copy link
Collaborator

Just realised I didn't add a 404 page. Easy to fix, will commit directly to this branch (it won't affect what you've done).

@jonodrew jonodrew force-pushed the write-docs branch 2 times, most recently from 9fe7523 to 2f009ca Compare August 21, 2022 08:05
@jonodrew jonodrew marked this pull request as ready for review August 21, 2022 08:11
@jonodrew jonodrew requested a review from johnpeart August 21, 2022 09:10
@jonodrew
Copy link
Owner Author

@johnpeart can you please look over the documentation and tell me what you think? Also add the privacy and cookies stuff, if you like

@johnpeart
Copy link
Collaborator

Not entirely sure why, but on the Cookies page from :5001, the change we previously made seems to have disappeared!
This was mentioned in #103

@johnpeart
Copy link
Collaborator

Looks good.

I've made a few changes – mostly just to make it a bit more assertive in places (as a bit of a software noob, I always find the more explicit the docs are and the plainer the English, the better!).

I've also moved the other docs across as discussed.

I've also added a 'Contributing' and 'Licences' page.

I assume you want to release this under the Open Government Licence v3.0? That's what GOV.UK uses and it's what we've used on other stuff we produce.

We'll need to redirect "/cookies" and "/privacy" from Redis to Jekyll.
Is that just a case of changing the .route("/cookies") to .route("http://docs.mentoring.service.civilservice.lgbt/cookies")?

@jonodrew
Copy link
Owner Author

Looks good.

I've made a few changes – mostly just to make it a bit more assertive in places (as a bit of a software noob, I always find the more explicit the docs are and the plainer the English, the better!).

I've also moved the other docs across as discussed.

I've also added a 'Contributing' and 'Licences' page.

I assume you want to release this under the Open Government Licence v3.0? That's what GOV.UK uses and it's what we've used on other stuff we produce.

Yup, it's produced mostly on work time.

We'll need to redirect "/cookies" and "/privacy" from Redis to Jekyll. Is that just a case of changing the .route("/cookies") to .route("http://docs.mentoring.service.civilservice.lgbt/cookies")?

Almost! We'll need to do a redirect(<url>), and make sure we've got a clean way for the user to get back to where they were

Would you mind also then adding something to CHANGELOG.md, detailing the changes? Under a new heading, 2.6.0

@johnpeart
Copy link
Collaborator

The last commit (ff5c1fe) should (I hope!) fix the routing.

[...] and make sure we've got a clean way for the user to get back to where they were

I suggest we handle this through links added to the header and footer. Can I suggest we create a separate branch for this, that encompasses fixing all the navigation?

@johnpeart
Copy link
Collaborator

Aside from the docs you need to add to, I think my work on this branch is done!
I will create a new branch to fix the navigation across the header, footer and breadcrumbs.

Copy link
Collaborator

@johnpeart johnpeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more doc to write up (aws.md) and there's a missing https:// in the Notify doc. Aside form that, looks good to go!

jonodrew and others added 11 commits August 31, 2022 08:20
This adds documentation for installing, building, and running the service locally
This adds content about notifications, how long the content is kept, and
how to alter that
The template already existed from the main site, so can just add straight in!
Developers can now run `docker-compose up` to run the docs locally, and on the same system. To run only the docs, don't forget to expose the port `-p 4000:4000` and mount the volume `-v /docs:/srv/jekyll`
For some reason the Gemfile in `/docs` was empty and preventing the build `docker-compose build` command from completing successfully.
I’ve added some information to the landing page of the docs to explain what they are and how to contribute.
Suggested changes to ‘Getting started’ to make the modal verbs a bit more forceful.
Suggested edits to make this a bit more directive.
I’ve also amended the link to the repository so that it is more obvious to a screen reader where the link goes.
johnpeart and others added 14 commits August 31, 2022 08:20
Add a contributing page and link to it from the “Getting started” page.
Can’t think of a better name for this at the moment!
Include link to roadmap
@jonodrew can you check this specifically please?
These pages used to live in the app; now they live in the docs.
@jonodrew

I’ve amended the licence file in the docs to link to the OGL licence

I’ve also removed the MIT licence from the LICENCE file in the root folder and replaced with the OGL licence.
This reverts commit cfe692e.
@johnpeart johnpeart merged commit 7229b05 into main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write up how to deploy the system
2 participants