fix: add field tracking #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranVanBelle
force-pushed
the
fix/add-field-tracking
branch
4 times, most recently
from
7deaf4e to
7186b01
Compare
jonas-grgt
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Nice job!
Most of the comments are nitpicking but there is one no-go for in there that definitely needs some attention.
Setting the boolean that keeps track of whether a field is encapsulated inside the RequiredField implementation and should be removed from the builder class itself.
processor/src/main/java/io/jonasg/bob/BuilderTypeSpecFactory.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/io/jonasg/bob/BuilderTypeSpecFactory.java
Outdated
Show resolved
Hide resolved
JoranVanBelle
force-pushed
the
fix/add-field-tracking
branch
from
dd7041b to
7035309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.