Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to include additional mutation scores visualization #13

Merged
merged 10 commits into from
May 22, 2024

Conversation

PlushZ
Copy link
Contributor

@PlushZ PlushZ commented May 7, 2024

Hi,
thank you @jonas-fuchs for this great tool.

I created this PR to introduce the option for visualizing additional scores such as MAVE affinity, expression, and antibody escape scores derived from deep mutational experiments. When the -s parameter is utilized and corresponding scores are available, the visualizations of these scores are incorporated into the plot. Otherwise, the plotting functions as usual.

@jonas-fuchs
Copy link
Owner

Hi ho, this is cool 😄. Thanks for the PR! Give me a bit to properly review the code (likely sometime next week). Some plotting issues I spotted just from the example pngs that would improve the overall vis:

  • Heatmap cells are not squares in all cases: I suspect that this might be caused by the y plot size.
  • Some whitespace could be introduced between the genome vis and the score tracks so that the score vis does not leak into the genome vis.
  • Location of the score legend seems to be random?
  • The mutation frequency legend is now not fixed anymore to the upper and lower y-boundaries of the heatmap.

@jonas-fuchs jonas-fuchs added the enhancement New feature or request label May 7, 2024
@jonas-fuchs
Copy link
Owner

Hi ho, so I had some time and did tried to correctly map all the coordinates. Did not fix the cbar plotting issue but I got an idea :D

CHANGELOG (so far):

  • fixed the y coordinates for the score tracks
  • introduced some spacing between the genome vis and the score tracks so that both do not overlap
  • Heatmap squares are square
  • cbar for the heatmap has now the correct location

Have tested this a bit, but I will try to test everything as soon as I fixed the score cbars

@jonas-fuchs
Copy link
Owner

@PlushZ I have rewrote quite a bit of your plotting code. Matplotlib makes it difficult to really fix colorbars in a right way and everything I tried did result in quite a bit of mayhem. So I came up with an hopfully clever solution to the problem. Could you have a look if this works for you?

test

@jonas-fuchs jonas-fuchs merged commit 7872df6 into jonas-fuchs:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants