fix: upgrade build deps, suppress directive warning on build (#146)

jonambas · Dec 27, 2023 · 0faad69 · 0faad69 · vercel · Dec 27, 2023
1 parent 2651918
commit 0faad69
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 35 deletions.
diff --git a/lib/makeViteConfig.ts b/lib/makeViteConfig.ts
@@ -55,6 +55,14 @@ export const makeViteConfig = async (
         input: {
           main: resolve(dirname, 'index.html'),
           preview: resolve(dirname, 'preview.html')
+        },
+        // Supresses module directive warning
+        // See https://github.com/rollup/rollup/issues/4699
+        onwarn: (warning, warn) => {
+          if (warning.code === 'THIS_IS_UNDEFINED') {
+            return;
+          }
+          return warn;
         }
       }
     },

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,6 +2,7 @@
   "name": "@sweatpants/libra",
   "version": "0.0.37",
   "description": "",
+  "type": "module",
   "publishConfig": {
     "access": "public"
   },
@@ -87,7 +88,7 @@
     "react": "18.2.0",
     "react-dom": "18.2.0",
     "rimraf": "5.0.5",
-    "rollup": "2.79.1",
+    "rollup": "4.9.1",
     "rollup-plugin-esbuild": "6.1.0",
     "typescript": "5.2.2",
     "wait-on": "7.2.0"

diff --git a/rollup.config.js b/rollup.config.js
@@ -1,7 +1,7 @@
 import { defineConfig } from 'rollup';
 import esbuild from 'rollup-plugin-esbuild';
 import cjs from '@rollup/plugin-commonjs';
-import pkg from './package.json';
+import pkg from './package.json' assert { type: 'json' };
 
 const config = defineConfig({
   input: 'lib/index.ts',

diff --git a/tests/react-18/files/component.tsx b/tests/react-18/files/component.tsx
@@ -0,0 +1,3 @@
+'use client';
+
+export const ClientComponent = () => <div>Client Component</div>;
diff --git a/tests/react-18/files/test.libra.tsx b/tests/react-18/files/test.libra.tsx
@@ -1,3 +1,5 @@
+import { ClientComponent } from './component';
+
 directory('folder 1', () => {
   add('story 1', () => {
     return <div>folder 1 story 1</div>;
@@ -29,3 +31,7 @@ add('root story 1', () => {
 add('root story 2', () => {
   return <div>root story 2</div>;
 });
+
+add('client component', () => {
+  return <ClientComponent />;
+});
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		'use client';

		export const ClientComponent = () => <div>Client Component</div>;