Carlo Echeverri - Personal Website #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
|
|
||
| </head> | ||
| <body> | ||
| <div class="container navbar"> |
There was a problem hiding this comment.
no need for this div, just put these classes on the header.
index.html
Outdated
| </nav> | ||
| </header> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Use sections instead of div
index.html
Outdated
| issues and complex challenges. I want to advance my career | ||
| into the technology sector where I can contribute to the | ||
| innovations that will keep advancing humanity. </p> | ||
| <br> |
There was a problem hiding this comment.
Try to avoid using br tags. Use css to style breaks if you need them.
portfolio.js
Outdated
| } | ||
| }) | ||
|
|
||
| // When the user scrolls the page, execute myFunction |
There was a problem hiding this comment.
Good to remove dead or unused code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.