v3.0 #171
Merged
v3.0 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
allerter
changed the title
…st_songs doesn't return that key in song info) - types.Song: removed Song.instrumental - clean_str(): change normalization method to NKFC - docs/snippets: changes in snippets titles
- added Track type - docs: added 'release_data' to sort options in artist_songs - docs: added track docs
allerter
changed the title
- added __repr__ for track
- updated snippets - added InvalidState for when self.state and passed state don't match
- moved InvalidState exception to errors.py
- fixed prompt_user to allow the code flow
- added some tests for auth
…resent in env vars fixed page_data for song which returned 404
This was
linked to
issues
Jan 27, 2021
Closed
(genius adds this character before strings that their first letter is lower case)
allerter
commented
Feb 7, 2021
|
The PR is ready to go. All tests are passing locally for me. Thank you for your hard work on this, @allerter. Should we update the package version to 3.0.0? |
|
The tests passed on Travis CI too. I think we're ready to go. |
|
I forgot to update the release notes in the docs and on GitHub's Releases page. Please merge this PR after I commit the release notes. |
johnwmillr
previously approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Thanks again for the excellent PR, @allerter. I will merge it once you've finished the release notes.
|
Happy to contribute, @johnwmillr. |
johnwmillr
approved these changes
Feb 9, 2021
|
3.0.0 is live on PyPi! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typesattributes using the information in docstrings but they looked a bit messy. So I removed them and manually put them in a table in docsalbum.songstoalbum.tracksTracktype (Note: On Genius a track just has thenumberandsongattributes, but sinceTrackinheritsBaseEntityit will have a redundantidattribute andTrack.id == Track.song.id.)