-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vcr support for consistent tests #109
base: master
Are you sure you want to change the base?
Conversation
Hi @ludehon, sorry for the delay. Do you mind adding a demonstration of how to run these VCR tests? |
Reading the Rationale on VCR's docs, I think this might be a good idea. Currently, the tests take about 3:20 minutes on Travis CI and even longer on local machines. |
Using VCR without the libyaml extension the tests took 105 seconds on my PC. It's also nice to be able to run the tests offline. |
Do you mind addressing these merge conflicts, @allerter? |
@johnwmillr, not at all. I had actually tried this out a while ago. So this won't take much time. |
A few notes:
|
|
@johnwmillr if you think using |
You're right, @allerter. For the sake of moving forward with 3.0, let's hold off on this PR for now. I won't close it just yet, but we can move forward with the 3.0 work without merging this in. |
Only tests functions that use HTTP will have the vcrpy decorator