Project 3 #71
Open
Project 3 #71
+632
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbeve
requested changes
Apr 1, 2023
| (b) Transitive | ||
|
|
||
| The object property, “existence ends with”, should have the transitive characteristic listed. |
There was a problem hiding this comment.
Very good. We should discuss these and consider having you post on the RO issue tracker: https://github.com/oborel/obo-relations
| (b) Transitive | ||
|
|
||
| The object property, “aligned with”, should not have the transitive property listed. Finn: |
| Tuesday instance_of one-dimensional temporal region | ||
| Wednesday instance of one-dimensional temporal region | ||
| Arm instance_of fiat object part | ||
| “Sally participates in having at least one arm on Tuesday” instance of occurrent |
There was a problem hiding this comment.
What exactly is an instance of occurrent here? A proposition?
| Liver is a class in Uberon (UBERON_0002107), which is a subclass of material entity. | ||
| https://ontobee.org/ontology/UBERON?iri=http://purl.obolibrary.org/obo/UBERON_0002107 | ||
|
|
||
| Argument ex auctoritate from BS for the object property has_part_at_all_times: |
| Marriage instance_of occurent | ||
| “Three years span 1” instance_of one-dimensional temporal region. | ||
| Notice that the original phrase doesn’t say anything about Goofus and Gallant being | ||
| married to each other, and we won’t represent such a fact. |
| C (x, t) = being a child at t | ||
| A (x, t) = being an adult at t | ||
| S (x, t) = being a senior at t | ||
| ∃t1∃t2∃t3 (C (j, t1) ∧ A (J, t2) ∧ S(J, t3) ∧ E (t1, t2) ∧ E (t1, t3)) |
There was a problem hiding this comment.
Your relation 'being earlier than' is underspecified. As it stands, the relation permits models in which E(t3, t1) holds as well.
| (d) Goofus and Gallant have been married for three years; for each day of that span, | ||
| it is true to assert they are married. | ||
|
|
||
| Again, notice we are not modeling that Goofus and Gallant are married to each other. |
|
|
||
|
|
||
| 6. Using Protege, place these in the BFO hierarchy where you think they fit best: | ||
| ``` | ||
| Some of these questions are of course ambigous. In a real-life situation, we would talk with | ||
| the domain experts/ client who asked us to build the ontology and understand what of the |
| (c) SARS-CoV-2 | ||
| Role | ||
| (c) SARS-COV-2 | ||
| Object (apparently we use this term to refer to the virus, not the disease/ disorder) |
| (d) An organization may have no members as part. | ||
| If organizations are object aggregates, this is false. |
There was a problem hiding this comment.
The current specification allows that organizations may have no members at some point, but they must've had members when created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello John,
this is a pull request for Project 3.
I have closed the pull request for Project 2 since you already commented on it and I couldn't open a new one without closing the old one apparently.
Let me know if everything works!