Add multilingual check to optionally display language selection. Fixe… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…joeroe#71 The `hugo.IsMultilingual` function (https://gohugo.io/functions/hugo/ismultilingual/) can be used to test if there is more than one configured language. If not, we just skip including the language selection partial layout. It can mistakenly appear for mono-lingual sites/content because it is always included, and the `lang.html` partial layout seems to iterate through the entire range of configured languages, even when it's only one language. Requires Hugo v0.124.0 or newer.
|
I ran across the "$echo $LANG" issue and came up with a quick solution. I haven't read your repo enough to know if you have requirements for supporting older versions of Hugo, but the function I'm using was added a few months ago. This was just a quick change, let me know if there's any adjustments you need before accepting the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s #71
The
hugo.IsMultilingualfunction(https://gohugo.io/functions/hugo/ismultilingual/) can be used to test if there is more than one configured language. If not, we just skip including the language selection partial layout. It can mistakenly appear for mono-lingual sites/content because it is always included, and the
lang.htmlpartial layout seems to iterate through the entire range of configured languages, even when it's only one language.Requires Hugo v0.124.0 or newer.