Prototype Literal::Array #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
force-pushed
the
prototype-literal-array
branch
from
600bf25 to
3764c17
Compare
joeldrapper
commented
Nov 8, 2024
lib/literal/array.rb
Outdated
Comment on lines
20
to
27
| def initialize(type, value) | ||
| unless Array === value && value.all?(type) | ||
| raise | ||
| end | ||
|
|
||
| @__type__ = type | ||
| @__value__ = value | ||
| end |
There was a problem hiding this comment.
We should probably allocate and call another method because this shouldn’t be called directly by a user.
joeldrapper
commented
Nov 8, 2024
Comment on lines
+8
to
+10
| def new(*value) | ||
| Literal::Array.new(@type, value) | ||
| end |
There was a problem hiding this comment.
This importantly makes a copy of the array since it picks up the splat. This is essential to maintain the integrity of the array, since otherwise it could be mutated elsewhere. This value should never be exposed. Even to_a should only expose a duplicate.
|
I’m going to merge this now so work on other methods can be parallelised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab at ##134.