Skip to content

Commit

Permalink
Merge pull request adaptlearning#27 from irisEd/issue_1419
Browse files Browse the repository at this point in the history
Fix for assessment results not consistently being marked complete in some contexts
  • Loading branch information
brian-learningpool authored Feb 15, 2017
2 parents 66a3ce2 + f17cfc7 commit fb0c4ad
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion js/adapt-contrib-assessmentResults.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,13 @@ define(function(require) {

if (this._isVisibleTop || this._isVisibleBottom) {
this.setCompletionStatus();
this.$el.off("inview");

// Sometimes (with mobile and virtual keyboards) inview can be triggered
// but the component is not _visible = true, so it does not get marked
// complete. Delay the unbinding of the inview listener until complete
if (this.isComplete()) {
this.$el.off("inview");
}
}
}
},
Expand Down

0 comments on commit fb0c4ad

Please sign in to comment.