Various changes #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Creates a new private struct called `PitchController`. * Moves details of frequency, MIDI pitch, and detuning into `PitchController` so `Oscillator` has to deal with as little of it as possible on its own. * Renames `OscMode` to `PitchMode`. * Renames `Message::OscMode` to `Message::PitchMode`. * Renames `Oscillator::set_coarse_detune()` and `Oscillator::set_fine_detune()` to `detune_coarse()` and `detune_fine()`. * Removes or strips down several `Oscillator` methods/fields to reference or call `PitchController` instead.
This commit: * Adds a test module `pitch_control_tests` to provide basic checks for `PitchController` functionality. * Removes an unnecessary `mut` from `PitchController::get_freq()`.
This commit: * Allows `midi` to send `Message::PitchBend`. * Implements the function `PitchController::pitch_bend()`, which uses bit operations to convert the MIDI bytes to a usable value. * Updates `PitchController::get_freq()` to use the pitch bend value. * Adds a `byte_conversion_is_correct` test to `pitch_control_tests`.
This commit replaces tuple-like enum variants with struct-like variants for all `Message` types containing multiple values. This allows for greater clarity of purpose via named fields.
This commit fixes an issue where double-clicking some knobs to reset their value to default would not affect the synthesizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge various changes made on the pitch_wheel branch by accident.