Use COMPLETE category when sync finishes #1385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lord-ne
changed the title
|
@kaiserbh I just want to confirm, is there any specific reason why currently the sync uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categorize sync complete/error notifications as
CHANNEL_BACKUP_RESTORE_COMPLETEinstead ofCHANNEL_BACKUP_RESTORE_PROGRESS. This matches the behavior of the BackupNotifier.This doesn't completely fix #1325, but it's a low-hanging fruit to improve the experience somewhat.