Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use C#7 features #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apkd
Copy link
Contributor

@apkd apkd commented Oct 26, 2019

This pull request introduces a number of non-functional changes that are intended to make code more concise and readable. These include:

  • Usage of expression-bodied members in short methods and getters (a lot of those!)
  • Usage of pattern matching to simplify type tests
  • Usage of local functions

All these dropped braces sometimes amount to a 20%-30% decrease in line count per file. Obviously these are stylistic changes so it's up to your opinion whether merging these changes represents an improvement.

Copy link
Owner

@joashc joashc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, this makes things a lot cleaner.

Getting some merge conflicts here after merging #6, if you fix those I'll get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants